search

iamcco / coc-diagnostic

diagnostic-languageserver extension for coc.nvim
245 stars 22 forks source link

Revert "Prefer space indentation on shfmt" #124

Closed lithammer closed 2 years ago

lithammer commented 2 years ago

This reverts #119.

See https://github.com/iamcco/coc-diagnostic/pull/119#issuecomment-1033555114 for more details, but the tl;dr is that setting a this flag causes shfmt to ignore EditorConfig settings.

If any parser or printer flags are given to the tool, no EditorConfig files will be used.

lithammer commented 2 years ago

CC @mosheavni

mosheavni commented 2 years ago

Looks like editorconfig is considered this time so this value is not needed anymore. I'm good with this PR.