search

iamchrismiller / grunt-casper

Run CasperJS Scripts/Functional Tests
Other
69 stars 38 forks source link

Respect the force #57

Open zinefer opened 9 years ago

zinefer commented 9 years ago

Use grunt.util.async.queue if --ignore-fail is passed to grunt with the parallel option set.

iamchrismiller commented 9 years ago

I will check this out tonight/tomorrow and dig into queue errors a bit more. Thank you.

zinefer commented 9 years ago

Any update on getting this merged?

iamchrismiller commented 9 years ago

Sorry it took so long to take a look at this.

At a quick glance it looks good. A couple comments/questions though.

What is your reasoning for using this as a longopt and not a definition within the options block in the task options definition?

Also, a test ensuring the correct behavior should be included so we don't potentially break other implementations and an update to the readme as this is a new feature and should be documented.

Otherwise it looks good.