iamchrismiller / grunt-casper

Run CasperJS Scripts/Functional Tests
Other
69 stars 38 forks source link

fix for multiple files overwriting xunit option #7

Closed sojournerc closed 11 years ago

sojournerc commented 11 years ago

Thanks for the merge!

I found an issue where globbed files were overwriting the xunit option, and preventing subsequent tests from getting the correct path.

Fixed by letting options.xunit be defined during runtime depending on options.xunit_out

iamchrismiller commented 11 years ago

Good deal, Maybe a test around this would be nice. :)

sojournerc commented 11 years ago

writing the test now, but the tests don't complete

npm test runs, but hangs at:

Running "casper:args:baz:--foo=bar" (casper) task

if I comment that out it hangs at:

Running "casper:screenshots" (casper) task

what I am doing wrong?

iamchrismiller commented 11 years ago

Thats interesting.. I just ran npm test and it completed successfully.

What version of Grunt are you running?

Here's my current npm list for this repo's grunt dependencies

├─┬ grunt@0.4.1 ├── grunt-contrib-clean@0.4.1 ├── grunt-contrib-internal@0.1.2 ├─┬ grunt-contrib-jshint@0.1.1 ├─┬ grunt-contrib-nodeunit@0.1.2 └── grunt-lib-contrib@0.4.0

sojournerc commented 11 years ago

I have the same versions. How about:

$ casperjs --version
> 1.1.0-DEV
sojournerc commented 11 years ago

I moved down to version 1.0.2 and they work now

iamchrismiller commented 11 years ago

I will take a look at that sometime soon and see what they are changing in 1.1.0 and tag a new dev branch for those who like staying on the edge.

On Fri, Aug 9, 2013 at 1:05 PM, Christopher Meyer notifications@github.comwrote:

I moved down to version 1.0.2 and they work now

— Reply to this email directly or view it on GitHubhttps://github.com/iamchrismiller/grunt-casper/pull/7#issuecomment-22420068 .

iamchrismiller commented 10 years ago

@sojournerc I pushed a new branch 1.1 which updates the casper tests / lib to support the changes from 1.0 to 1.1.0-dev. I will leave this branch separate until 1.1 stable comes out and then I will merge to master. Feel free to grab the new branch