Open dzwarg opened 8 years ago
@iamchrismiller you should not depend on slimerjs in this project.
create engines like grunt-casper-slimerjs grunt-casper-phantomjs, then when someone sets:
{
"engine": "xyz"
}
do
var engine = require('grunt-casper-xyz').engine
Like babel etc.
Or even better support only:
{
"engine": require('grunt-casper-xyz').engine
}
phantomjs and slimerjs should be optDependencies rather then deps, otherwise it forces both to be installed; and i dont want slimerjs installed unless i am using it. For me on node 6.2.1 slimerjs is failing to build, and because of that grunt-casper wont install
That's not how optional dependencies work... On 13 Jun 2016 20:27, "Bernie" notifications@github.com wrote:
phantomjs and slimerjs should be optDependencies rather then deps, otherwise it forces both to be installed; and i dont want slimerjs installed unless i am using it. For me on node 6.2.1 slimerjs is failing to build, and because of that grunt-casper wont install
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iamchrismiller/grunt-casper/issues/75#issuecomment-225682729, or mute the thread https://github.com/notifications/unsubscribe/AAZQTKFYj8gZ1zQB4nqcM8nnhH3v97pzks5qLa80gaJpZM4Iw5Xp .
if its optional, the build doesn't fail when that component fails. As grunt-casper can work with one of the two failing, or even both failing with a global install(phantom/casper/slimer).That seems a better fit then installing both always, even though {engine:""} can only be set to one. With them listed as optional deps npm still tries to install them. This would allow the package to continue working as is, but with the intended effect.
@graingert's: I agree having a base package and 2 engine packages makes the most sense long term.
The chain of dependencies in grunt-casper explicitly uses slimerjs@0.9.6, which is no longer supported. Please update the dependencies to a supported version.