iamckn / wireguard_ansible

Ansible scripts for the set up a typical wireguard VPN connection
https://www.ckn.io/blog/2017/11/14/wireguard-vpn-typical-setup/
322 stars 69 forks source link

WTF?: RUNNING HANDLER [wireguard_role : Reboot the server] #15

Closed mabushey closed 5 years ago

mabushey commented 5 years ago

Seriously WTF? You're just going to reboot a server? This isn't Windows.

iamckn commented 5 years ago

I see no issue with rebooting a linux server. If your use case requires no reboots, I suggest you uncomment the reboot section.

mabushey commented 5 years ago

At a minimum, you need to tell people your script reboots the server. My opinion is this is not acceptable nor anything a competent perfessional would do. I don't mean this as an attack, your script works and has helped me, I'm just shocked it would reboot the server. Thank you for releasing this Ansible config.