search

iamcram91 / swdv-691

0 stars 0 forks source link

Home Page Image Carousel #8

Open MarvinJ514 opened 4 years ago

MarvinJ514 commented 4 years ago

First and foremost, I truly liked the inclusion of this feature within your project. I am not going to lie it made me think about adding a image carousel for my project as an added stretch feature. I do not really have an issue with the current configuration of the feature, aside from an aesthetic suggestion. For the sake of maintaining a designated for the carousel, I would suggest either maintaining a standardized size for your images or standardize the height of your division element that encloses your carousel component. This would prevent the various images from resizing the height of your overall page pushing the location of your footer. I think the styling can be done with one of these div containers within your home.html:

119 <div class="container"> 120 <div class="col-lg-12">
122 <div id="myCarousel" class="carousel slide" data-ride="carousel">

iamcram91 commented 4 years ago

Thanks, Marvin! My main focus was on the registration and login page this week. This is an easy enough change and I like your take on the container updated. I'll make those tickets in the project and get those done this week Thanks again!