iamdork / compose

Command line replacement for docker-compose, adding dork magics.
MIT License
2 stars 2 forks source link

Add ability override the domain #50

Closed sepal closed 7 years ago

sepal commented 7 years ago

This PR adds a new variable DORK_PROXY_VIRTUAL_HOST, which allows you override the domain for a site. The new variable is needed, because only checking for the VIRTUAL_HOST in the proxy.preprocess_config function would only allow you to set the domain per docker-compose config, but in our case we want to set it per site we up in an .env file. It is also probably cleaner if all the associated services (like a phpmyadmin container) run under the same domain. Currently the domains of subservices are also splitted by two dashes, I'm not sure if we should actually split by a dot, so that they run a sub domain (i.e. phpmyadmin.example.dork).