search

iamed2 / ResultTypes.jl

A Result type for Julia—it's like Nullables for Exceptions
Other
95 stars 8 forks source link

Add SafeBase Module #29

Open 0x0f0f0f opened 2 months ago

0x0f0f0f commented 2 months ago
0x0f0f0f commented 2 months ago

@iamed2 would you have a moment to take a look at this?

iamed2 commented 2 months ago

I can look more this weekend, in the meantime can you make src/SafeBase.jl more BlueStyle? And add signatures to the new method docstrings that don't contain them.

0x0f0f0f commented 2 months ago

@iamed2 addressed the comments. Thanks!

0x0f0f0f commented 1 month ago

Can I go ahead and merge? @iamed2