search

iamfmjk / etsy

A friendly Ruby interface to the Etsy API
https://github.com/kytrinyx/etsy
MIT License
171 stars 113 forks source link

CI is failing, jruby this time #117

Open kytrinyx opened 7 years ago

kytrinyx commented 7 years ago

I'm tempted to stick jruby on the "allowed failures" list. I suspect that if you're writing an etsy app, you're not deploying it on rubinius or jruby. It might be OK to deprecate support for these.

mattrayner commented 7 years ago

Looking at the error we're getting to do with JSON, and the future Faraday roadmap, ruby as an 'allowed failure' seems okay.

As part of the future work we are doing we can re-address the rubinius and jruby compatibility issues?

kytrinyx commented 7 years ago

As part of the future work we are doing we can re-address the rubinius and jruby compatibility issues?

Yeah, that sounds like a good idea.