iamgreaser / iceball

Open-source rewrite of the VOXLAP version of Ace of Spades.
http://iceball.build
GNU General Public License v3.0
113 stars 32 forks source link

Safer engine functions #133

Open BR- opened 9 years ago

BR- commented 9 years ago

common.map_set will crash if called on an improper map. It should instead throw a Lua error. I suspect there are many other functions like this.

rakiru commented 9 years ago

Something in the networking will crash too. I think net_unpack may crash if the buffer isn't long enough. net_pack should probably be checked too (then again, most of them should probably at least get a look at them).

LeComm commented 9 years ago

Especially the map functions are REALLY crashy, partly because of all the "dirty" pillar/column stuff. I wonder why iceball uses the vxl format instead of something like in PySnip.

iamgreaser commented 9 years ago

Because it's faster to look geometry up with and it uses less memory.