search

iamgreaser / iceball

Open-source rewrite of the VOXLAP version of Ace of Spades.
http://iceball.build
GNU General Public License v3.0
113 stars 32 forks source link

Make the WAV parser less easy to break #263

Closed rakiru closed 8 years ago

rakiru commented 8 years ago

Mostly checks to avoid overflows. There is one NULL check that I added early on as it was really easy to trigger. It's probably less useful now that there are a bunch of checks before it that should stop stupid things like trying to malloc a negative number...

iamgreaser commented 8 years ago

OK I'm supposed to write a comment here or something

The code looks like an improvement over the current code

You might as well just merge it