search

iamgreaser / iceball

Open-source rewrite of the VOXLAP version of Ace of Spades.
http://iceball.build
GNU General Public License v3.0
114 stars 32 forks source link

User keeps walking after having finished typing #38

Closed ucarion closed 11 years ago

ucarion commented 11 years ago

If a user is walking and types 't' to start a comment, he keeps walking as expected... but the weird part comes when after he's entered text, he keeps on going in the direction he had been going while typing and cannot regain proper control of movement until he again presses the button he had been holding when he started typing.

To recreate the bug:

Walk forward, and while doing so press 't'. Enter a chat / message / whatever it's called. The user continues to move forward. Try to move backwards, you stay put.

I think the solution is just to set the player to stop moving after entering a chat.

ucarion commented 11 years ago

One solution would be to do input_reset() at

https://github.com/iamgreaser/buldthensnip/blob/master/pkg/base/obj_player.lua#L1736

Or something --- the problem with input_reset() is that it also makes the user stand up.

rakiru commented 11 years ago

It would be weird to finish walking when typing. Expected behaviour for this kind of thing (in my eyes) is to either release keys when you start typing, or release keys when you let go of them. Releasing keys because you hit enter just seems wrong, although I understand this may seem sensible if you think of it as pausing input processing for movement while chat is up.

rakiru commented 11 years ago

This is 8 months old, so I'm going to assume (due to lack of comments/patch) that current behaviour is what's desired. Feel free to reply if not.