Skaven - Beyond The Network

iamgreaser / libit216

C port of Jeffrey Lim's Impulse Tracker source code release

Other

18 stars 1 forks source link

Skaven - Beyond The Network #12

Open iamgreaser opened 8 years ago

iamgreaser commented 8 years ago

~~WARNING: This track doesn't even work in Impulse Tracker (it crashes when you hit play), so I'm only focusing on the blatant issues.~~ I have fixed this track such that it plays in IT 2.14p5 without issues. At least as far as I know. I'm almost a minute in and it's a ~30-min track.

~~A lot of notes fail to allocate at all.~~ NOT A BUG, THIS TRACK FALSELY MARKS INSTRUMENTS AS MIDI WHICH DOES NOT PLAY ON THE MIXER IN IT ITSELF (I have another track which has this issue too which DOES play in IT)
[ ] Whatever else is discovered.

iamgreaser commented 8 years ago

Note allocation issue narrowed down to instrument translation when a MIDI channel is selected (see "Have to xlat" comment). When we force it to ignore the MIDI channel, it works fine.

UPDATE: Tested an offending track in IT - turns out that instrument IS muted when the driver doesn't use MIDI.

sagamusix commented 8 years ago

Before you are going to figure out even more things that sound wrong: Pitch envelope loops were one tick too short in MPT 1.16 (i.e. treated like XM envelopes), hence all the arpeggiated instruments will have a different timing than in MPT. OpenMPT automatically fixes it when loading the file by inserting another envelope point one tick before the loop end and then moves the loop end there. And obviously it uses stereo samples which won't work in IT.