Allow option to lock aspect ratio

gianpaj commented 7 years ago

First of all thanks a lot for putting this plugin together! The current ionic-native one is very basic and simple things like 90-degree rotation should be supported.

If it would be possible to lock the aspect ratio, that would be super cool :)

BTW, i was getting an issue installing this plugin. I think the js file is called icrop.js in https://github.com/isathyam/cordova-plugin-icrop/blob/master/plugin.xml#L20

but i'm not an expert in cordova plugins.

$ cordova plugin add --save cordova-plugin-icrop
Installing "cordova-plugin-icrop" for android
Error during processing of action! Attempting to revert...
Failed to install 'cordova-plugin-icrop': Error: Uh oh!
ENOENT: no such file or directory, open 'app/plugins/cordova-plugin-icrop/www/crop.js'
    at Error (native)
    at Object.fs.openSync (fs.js:641:18)
    at Object.fs.readFileSync (fs.js:509:33)
    at install (app/platforms/android/cordova/lib/pluginHandlers.js:173:36)
    at Object.process (app/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
    at PluginManager.doOperation (app/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:117:20)
    at PluginManager.addPlugin (app/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:147:17)
    at app/platforms/android/cordova/Api.js:254:18
    at _fulfilled (app/platforms/android/cordova/node_modules/q/q.js:854:54)
    at self.promiseDispatch.done (app/platforms/android/cordova/node_modules/q/q.js:883:30)
Error: Uh oh!
ENOENT: no such file or directory, open 'app/plugins/cordova-plugin-icrop/www/crop.js'

iamisathya commented 7 years ago

Thank you for using plugin. I will check that issue

gaurav-vachhani commented 7 years ago

I am also facing the same issue. Any update on this?

iamisathya commented 7 years ago

Hi,

Thank you for using my plugin

Sorry i was bit busy with my projects.. Will update the code soon.. May be by Tuesday or Wednesday

Thank you for rising issue..👍

Regards, iSathya

On 15-Sep-2017, at 3:04 PM, Gaurav Vachhani notifications@github.com wrote:

I am also facing the same issue. Any update on this?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

antoniomatiolijr commented 7 years ago

Some news? I think the error is "icrop.js" name, the plugin config xml has wrong path to "crop.js"

jamesalanfinnigan commented 6 years ago

After you receive the above error, rename the www/icrop.js to crop.js and rerun the same command.

iamisathya / cordova-plugin-icrop

Allow option to lock aspect ratio #1