iamjackg / md2cf

Convert and upload Markdown documents to Confluence
MIT License
91 stars 50 forks source link

Add .gitignore support #36

Closed bjorns closed 2 years ago

bjorns commented 2 years ago

Read .gitignore files in the repo and use them to skip ignored files from upload.

Flag --no-gitignore disables the functionality.

iamjackg commented 2 years ago

Thanks for the PR! I fully support this and I think it's a great idea, but I have a few suggestions:

It would be nice to also add a test or two for this :)

bjorns commented 2 years ago

Alright, so I've added a test and a --no-gitignore flag. I didn't add the -I flag because none of the other directory flags had a short form. Maybe that's something you want to add in a concerted way instead?

Also unit test added.

bjorns commented 2 years ago

@iamjackg pinging this again, I've made the requested upgrades. Would be super useful to have it in a release version.

iamjackg commented 2 years ago

Thank you so much for working on this, I'll take a look soon.