search

iamjackg / md2cf

Convert and upload Markdown documents to Confluence
MIT License
93 stars 52 forks source link

fixed issue where paths with spaces were not supported #75

Closed mschmieder closed 1 year ago

mschmieder commented 1 year ago

Hey,

me again :)

I noticed that one important piece did not make it into your great re-implementation of the follow-links feature. You are missing the unquote of paths as markdown does not support spaces or any special characters in the relative links, which makes it necessary to url-encode that paths. The current implementation does not take that into account which is why files i.e. with a space (encoded %20) cannot be found and are reported (falsely) as not being available

[Some Link](../this%20is/not%20working.md)

The fix is minor and should not have any side-effects.

alfechner commented 1 year ago

We ran into the exactly same issue, thanks so much @mschmieder for taking care of this.

Hope this makes it into the trunk soon.