search

iamjackg / md2cf

Convert and upload Markdown documents to Confluence
MIT License
91 stars 49 forks source link

added retry attempts #99

Closed mschmieder closed 1 year ago

mschmieder commented 1 year ago

Hi @iamjackg

I did another quick improvement on the code as we are facing a lot of issues uploading large numbers of documents to Confluence (Atlassian.com). We get sporadic 500 errors that make it almost impossible to get the process to finish completely which is especially bad when using relative links as it leaves the documents unpatched.

I did use tenacity to do a super simple retry on the upload logic. The number of attempts can be changed using --retry-attempts

Obviously the error handling could be done more sophistically, but for us this works 100%!

Cheers, Matthias

iamjackg commented 1 year ago

I merged this, and while reviewing it I remembered that I had actually already added support for retries, but only for 429 Too Many Requests responses. I'll just make that apply to all errors instead: that way we don't need to rely on another library :)