iamjamestan / pe

0 stars 0 forks source link

Not allowed to add book with same name and genre #1

Open iamjamestan opened 4 years ago

iamjamestan commented 4 years ago

When i wanted to add a book with the same name and genre twice, the system did not allow me to do so, even though it was not stated in the user guide that adding books with the same name and genre are not allowed. This confuses the users as to what constitutes as duplicates in the system.

Steps to reproduce:

  1. Type add n/Harry Potter g/Fiction t/Magic t/Witches tp/500 b/10 and hit enter
  2. Type add n/Harry Potter g/Fiction tp/50000 b/10 and hit enter

Screenshot 2020-11-13 at 4.24.18 PM.png

nus-se-bot commented 4 years ago

Team's Response

We will add an additional note to inform users what it means for a book to be a duplicate.

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: In the CS2103T website, it states that any "behaviour that differs from the User Guide" are considered as functionality bugs.

Screenshot 2020-11-18 at 4.02.42 PM.png

Since the User Guide clearly did not mention that we are not allowed to add books with the same name and genre, I should expect the system to accept books with same name and genre, as long as I am using the add command in the correct format as given in the UG. However, the system rejects my book, and the error message does not even inform me of such rules. Thus the behaviour differed from that of the User Guide and should hence be considered as a functionality bug.

I understand that this bug can easily be fixed by just adding a one liner to the UG. However, just because it can be resolved by adding one line to the UG does not automatically mean that it is a documentation bug. The following screenshot shows what constitutes as documentation bugs in the CS2103T website. They are mostly regarding neatness/readability/understandability, etc., which is not what I am reporting here. Screenshot 2020-11-18 at 4.13.24 PM.png


:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]