iamjamestan / pe

0 stars 0 forks source link

Unclear of what reading progress is in sort command #3

Open iamjamestan opened 3 years ago

iamjamestan commented 3 years ago

The sort command allows us to sort by these fields: Screenshot 2020-11-13 at 4.42.03 PM.png

However, it is unclear of what "reading progress" is, since there is no field called "reading progress" in each book in the main window. It is hard to test as it does not allow the user to verify that the page has indeed been sorted by this "reading progress".

Screenshot 2020-11-13 at 4.47.30 PM.png

nus-se-bot commented 3 years ago

Team's Response

In the glossary of the UG (the last page), we provided the definition of what a reading progress is. Regarding it being hard to test, one can view the book to check the reading progress of the book and can also do their own manual calculations for reading progress by taking the bookmarked page divided by the total pages.

image.png

IMAGE 2020-11-14 16:19:44.jpg

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The developers refuted the claim that sorting by reading progress is hard to test by claiming that "one can view the book to check the reading progress of the book and can also do their own manual calculations for reading progress by taking the bookmarked page divided by the total pages."

However, if testers have to individually click on each book in order to check their reading progress or manually calculate the reading progress of each book, doesn't that make it hard to test? If there were 100 books in the system, that means that the tester has to click on all 100 of them seperately to check that all books are arranged in the correct manner.

What should have been done is that the panels in the main window should show the reading progress of each book, so that testers can verify that the books have indeed been sorted by reading progress in the main window. The lack of this implementation makes it hard to test and verify that the sort is actually working.

During the PE, when I entered the command to sort by reading progress, it seemed that the books were just randomly jumbled up. I had to individually click on each book to verify that it was indeed sorted by reading progress. Screenshot 2020-11-19 at 3.23.21 PM.png (image taken from the original bug report above)

I suggest the tutor to try sorting by reading progress and decide if my claims are fair. Thank you.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: According to the CS2103T website, severity.VeryLow are for bugs that are "purely cosmetic and does not affect usage". Screenshot 2020-11-19 at 3.41.14 PM.png

However, this bug clearly affects most testers who would be testing this product, since it is difficult to test. It also affects usage of this product as this flaw results in the "feature becoming less useful to the intended target audience" (definition of feature flaw as given in CS2103T website) Screenshot 2020-11-19 at 3.40.54 PM.png

Hence, I argue that this bug affects actual usage of the product, and should not be deemed as a very low severity.