search

iamkroot / asus-numpad

Linux driver for Asus laptops to activate numpad on touchpad
MIT License
34 stars 10 forks source link

The GX701 layout doesn't seem to be the correct one. #10

Closed UndeadKernel closed 2 years ago

UndeadKernel commented 2 years ago

I have a Zephyrus S GX701 and noticed that after installing the asus-numpad service, the layout was not the right one.

The original (python) repository defines the layout in this file. Your definition of the GX701 layout, found in here, does not match the original (and correct) one.

Was the change to the GX701 layout intentional?

iamkroot commented 2 years ago

That looks like a copy-paste error on my part. I must have copied the ux581 layout and forgotten to update it for gx701. Would you like to raise a PR with the correct one?

UndeadKernel commented 2 years ago

Sure thing, I'll post a Pull Request as I already have the correct layout. Though, I need a couple of hours to be back home.

On Wed, 5 Oct 2022, 16:20 Krut Patel, @.***> wrote:

That looks like a copy-paste error on my part. I must have copied the ux581 layout and forgotten to update it for gx701. Would you like to raise a PR with the correct one?

— Reply to this email directly, view it on GitHub https://github.com/iamkroot/asus-numpad/issues/10#issuecomment-1268503810, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPBEDQHXFSUHONNOJAHAEDWBWFEDANCNFSM6AAAAAAQ3AYIXU . You are receiving this because you authored the thread.Message ID: @.***>

UndeadKernel commented 2 years ago

I've addressed this issue in the PR #11 .