iamkroot / asus-numpad

Linux driver for Asus laptops to activate numpad on touchpad
MIT License
34 stars 10 forks source link

Enabled at startup seems to not work #27

Open akaibukai opened 3 weeks ago

akaibukai commented 3 weeks ago

Hello, First of all thank you for this! I tried another project that was working like a charm https://github.com//asus-linux-drivers/asus-numberpad-driver but it has a very noticeable (and annoying) delay for keypresses. On that repo there was your project linked as well - this is how I discovered it. In your project the key presses are almost instant which feels great.

However, it seems the touchpad presses are not handled the same way. On the other project, when the numpad is disabled (no lights) the numpad clicks AND taps are working.. Then when the numpad is enabled (lights on) the taps are disabled but the clicks are still enabled. Besides the clicks, the important thing to not it's that when it's disabled, the taps are still working.

In your driver, even when the numpad is disabled (no lights), the taps are not working at all..

So in order to handle that situation I thought I can simply set the following option disable_numlock_on_start = false and use a custom shortcut to launch/kill the tool altogether.. And call it a day..

This way, when the tool is not running at all, I'll have my taps and when the tool is launched - and enabled at startup - the tap will be disabled.

But that option seems to not be taken into account..

Also, when the numpad is enabled and that I kill the process, the lights remain switched on..

Is this the expected behavior?

BTW, here is the config file I'm using:

# /etc/xdg/asus_numpad.toml
layout = "UX581"
calc_start_command = {cmd = "gnome-calc", args = []}
disable_numlock_on_start = false

Thanks!

ldrahnik commented 1 week ago

https://github.com//asus-linux-drivers/asus-numberpad-driver but it has a very noticeable (and annoying) delay for keypresses.

Intended driver behaviour. By default are key presses send when is finger untouched. May be changed by config value. Was resolved in opened issue here.