search

iamkroot / trakt-scrobbler

Scrobbler for trakt.tv that supports VLC, Plex, MPC-HC, and MPV.
https://github.com/iamkroot/trakt-scrobbler/wiki
GNU General Public License v2.0
464 stars 30 forks source link

[Feature Request] add `send_immediately` to send "finished" status to trakt after watching >=80% to fix #202 #284

Open soredake opened 8 months ago

soredake commented 8 months ago

If this option is added, https://github.com/iamkroot/trakt-scrobbler/issues/202 can be considered as fixed, as finished state will be sent before changing file.

iamkroot commented 8 months ago

My main hesitancy with this is how to deduplicate the scrobbles. If we've already added it to history at 80% and then continue watching we need to remember not to scrobble again. And this needs to be persisted across many plays (you can close a file at 85%, come back tomorrow and play the rest of it.) Makes the logic a lot more complicated than what it is today.

If someone is willing to contribute with a simple PR, I'm willing to review.