search

iamkubi / pydactyl

Python wrapper for the Pterodactyl Panel API
MIT License
69 stars 21 forks source link

Implement servers.update_server_startup #41

Closed ens-gijs closed 2 years ago

ens-gijs commented 2 years ago

Resolves #40

iamkubi commented 2 years ago

Thanks for adding this. It looks like you discovered the catch that I didn't have time to deal with at the time, which was that you do need to specify all of the parameters even if you only change one.

Overall your approach looks good. It seems like you're testing it as you go - can you leave a comment once it's ready?

ens-gijs commented 2 years ago

It's in a working state now. However, I just started poking at the ptero API today with your library so I don't understand its quarks yet and I'm concerned about what changing the egg would do... I suspect this call might blow up if the old and new eggs had different environment fields and that if the egg is changed then this code should require the caller to pass environment and use it verbatim - or query the new egg and the env from it as the base... which may fail if the API key can't read eggs. There's probably more work to be done to round this feature out for the edge cases but it's more functional than "not implemented" ;)

ens-gijs commented 2 years ago

Bah, should have put that Nests change in a branch... Anyway, it's good to go now.