iamkubi / pydactyl

Python wrapper for the Pterodactyl Panel API
MIT License
67 stars 21 forks source link

added external id to server_create + update_server_details function #67

Closed globule655 closed 1 year ago

globule655 commented 1 year ago

I needed a way to insert an external id on server creation and also a way to update the server details after the fact. I didn't see a way to do it in your code so maybe you could consider it :)

Thanks for your great work by the way, it saved me a LOT of time

iamkubi commented 1 year ago

Looks good to me. Presumably you've tested these and they work?

codecov-commenter commented 1 year ago

Codecov Report

Merging #67 (6c969e9) into main (5d6af33) will decrease coverage by 1.10%. The diff coverage is 25.00%.

:exclamation: Current head 6c969e9 differs from pull request most recent head 6dcf6da. Consider uploading reports for the commit 6dcf6da to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   96.35%   95.26%   -1.10%     
==========================================
  Files          24       23       -1     
  Lines         824      824              
==========================================
- Hits          794      785       -9     
- Misses         30       39       +9     
Impacted Files Coverage Δ
pydactyl/api/servers.py 86.36% <25.00%> (-1.92%) :arrow_down:

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

globule655 commented 1 year ago

Yes I did test it in my lab environment. I just fixed a little typo in the json data of the update_server_details function and everything is fine now