iamkubi / pydactyl

Python wrapper for the Pterodactyl Panel API
MIT License
67 stars 21 forks source link

Bugfix: Shortcode != short #74

Closed devmaxde closed 8 months ago

devmaxde commented 1 year ago

The wrong param is used

devmaxde commented 1 year ago

https://dashflo.net/docs/api/pterodactyl/v1/#req_a52b4fb62ef7473db08747e8723ab425

iamkubi commented 1 year ago

The docs aren't always correct and links to specific functions have sadly never worked. Have you tested this?

codecov[bot] commented 1 year ago

Codecov Report

Merging #74 (c4033ac) into main (0e24d3c) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head c4033ac differs from pull request most recent head 2dccc18. Consider uploading reports for the commit 2dccc18 to get more accurate results

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files          24       24           
  Lines         828      828           
=======================================
  Hits          795      795           
  Misses         33       33           
Impacted Files Coverage Δ
pydactyl/api/locations.py 100.00% <100.00%> (ø)
devmaxde commented 1 year ago

Yeah. I saw that, because my program did some strange bugs

devmaxde commented 1 year ago

I can provide you a screenshot if you want

iamkubi commented 1 year ago

I can provide you a screenshot if you want

No worries, just checking if this was purely based on what the docs said or based on an actual bug. Totally believe it's not working and we'll get it fixed.

devmaxde commented 1 year ago

Update on that?

iamkubi commented 1 year ago

Update on that?

You never responded / fixed the review comment.

devmaxde commented 1 year ago

Fixed it by now :D