search

iamlikeme / rainflow

Implementation of the rainflow-counting algorythm in Python
MIT License
105 stars 34 forks source link

Produce sane results for very short time series #54 #56

Closed denis-jasselette-jc closed 2 years ago

denis-jasselette-jc commented 3 years ago

Following up on the discussion on issue #54.

denis-jasselette-jc commented 3 years ago

Not sure what could be causing the check to fail on one specific platform...

iamlikeme commented 2 years ago

Hey, just letting you know I haven't forgotten about this PR. I have just been rather busy recently.

CI fails because one of the "housekeeping" libraries, setuptools-scm does not play well with Python 3.4. The potential solutions are:

  1. To drop support for Python 3.4 (it is ancient anyways)
  2. To drop setuptools-scm in favor of some other tool, maybe poetry.

Either way it is something that has to be addressed in a separate PR before this one can be merged.

iamlikeme commented 2 years ago

I have rebased you branch onto master to pick up the fixed CI setup.

iamlikeme commented 2 years ago

Thank you for your contribution @denis-jasselette-jc :rocket: :star2: