search

iamlikeme / rainflow

Implementation of the rainflow-counting algorythm in Python
MIT License
105 stars 34 forks source link

Feature: Rainflow Matrix #6

Closed ghost closed 6 years ago

ghost commented 7 years ago

I would love to see the method described here in this library.

Is there a chance this could happen? :)

iamlikeme commented 7 years ago

I suggest that you fork the repo, implement the new method and make a pull request. You can start by writing a draft of the logic and a unit test. (Unfortunately, your link provides no numerical example with an answer... Maybe you have some example from your work or other sources that could be used for testing?)

We can then work together on sewing it together with the rest of the library. In it's current shape it is not designed to support different cycle counting algorithms, but I will be glad to rework it.

ramakrse commented 6 years ago

Me too, love to see such capability. Right now, this library gives range and count, it would be nice to extend to return range, mean with cycle count.

ghost commented 6 years ago

@ramakrse For now I could recommend https://github.com/Inqbus/inqbus.rainflow which provides this functionality.

iamlikeme commented 6 years ago

Hey @silentsnooc and @ramakrse. I made a pull request in an attempt to address your suggestion. It makes possible to extract cycle lows and highs. With that you can create a matrix or a from-to scatter plot yourself. Does it work for you?