iamlogand / republic-of-rome-online

An online adaptation of The Republic of Rome, a strategy board game
https://www.roronline.com/
MIT License
5 stars 2 forks source link

Fix the senator portrait image load issue #387

Closed iamlogand closed 9 months ago

iamlogand commented 9 months ago

Make senator images load quick, which closes #385. The solution was to reduce the size of the images and disable Next.js image optimization for them. Disabling image optimization has counterintuitively made the initial load times much quicker. Now, when the image first loads, it's cached and used again whenever that same image is needed, regardless of size. This means that when a senator is selected, the large image will always appear instantly because it's already been downloaded.

Next.js image optimization is bad for this use case (or I might be misusing it). However, the Next.js Image component is still marginally better than the standard image tag because of the placeholder prop, which is useful for users with particularly slow connections (e.g. slow 3G).