search

iammerrick / Kohana-Log-Email

A log writer that will email you important logs.
7 stars 3 forks source link

blank email reports #5

Open bumperbox opened 13 years ago

bumperbox commented 13 years ago

i am getting a number of blank email reports generated

I am not sure if kohana is calling logging incorrectly or not. but i had a look a the system logging code, and while they create the log file, they don't output anything if there are no messages.

whereas when you send via email, you are generating an email regardless of messages or not.

This is the fix I put in place, but not sure if this i the best solution, this is in the Log_Email class

public function write(array $messages)
{
    if (count($messages) == 0) {
        return;
    }
iammerrick commented 13 years ago

I will have a more solid fix for this thanks for finding!

On Jun 22, 2011, at 9:54 AM, bumperbox reply@reply.github.com wrote:

i am getting a number of blank email reports generated

I am not sure if kohana is calling logging incorrectly or not. but i had a look a the system logging code, and while they create the log file, they don't output anything if there are no messages.

whereas when you send via email, you are generating an email regardless of messages or not.

This is the fix I put in place, but not sure if this i the best solution, this is in the Log_Email class

public function write(array $messages) { if (count($messages) == 0) { return; }

Reply to this email directly or view it on GitHub: https://github.com/iammerrick/Kohana-Log-Email/issues/5