search

iammerrick / Squire.js

Your friendly dependency injector for testing Require.js modules.
MIT License
467 stars 59 forks source link

UMD wrap #65

Open dbartholomae opened 9 years ago

dbartholomae commented 9 years ago

Would it be possible to wrap the module in a universal module pattern so that it can be required in node? This would remove the additional work of setting up the module path via requirejs.config. More importantly, it would allow other node modules to use it without polluting global requirejs config space.

If this makes sense I could also create a pull request.

iammerrick commented 9 years ago

Let's do it :-)

— Sent from Mailbox

On Tue, May 26, 2015 at 11:53 AM, dbartholomae notifications@github.com wrote:

Would it be possible to wrap the module in a [universal module pattern][link] so that it can be required in node? This would remove the additional work of setting up the module path via requirejs.config. More importantly, it would allow other node modules to use it without polluting global requirejs config space. If this makes sense I could also create a pull request.

[link]: https://github.com/umdjs/umd/blob/master/returnExports.js

Reply to this email directly or view it on GitHub: https://github.com/iammerrick/Squire.js/issues/65

dbartholomae commented 9 years ago

I've created a pull request

dbartholomae commented 9 years ago

@iammerrick Did you have a chance yet to take a look at the pull request? :)

nicholaslee119 commented 7 years ago

Thanks for your work, that is what I need indeed.