iammert / AndroidArchitecture

Recommended architecture by Android
888 stars 192 forks source link

Android authenticator API #22

Open russellhoff opened 4 years ago

russellhoff commented 4 years ago

First, thanks for such a good work!!

I've a question for you, i don't know whether it's a feature request, suggestion or else. The API you're querying is protected by Tokens. In your application, your Token is hardcoded. What happens if your application needs the user to log in?

The token issue complicates and is a real world use case. Some people try to store tokens within SharedPreferences, but I don't think it's a good idea. I'm tackling it by using Android Accounts and Authenticator API. This is a good practice to manage accounts and tokens, since it provides mechanisms to update tokens in different situations.

It'd be nice that you could provide any example, in this project or in another. I understand this one is solely aimed to explaining the usage of MVVM arch.

Thank you again!