search

iammert / RadioPlayerService

Android service library which uses AAC Player. Ready to use Radio Player Service.
254 stars 90 forks source link

android.permission.READ_PHONE_STATE Requires Privacy Policy #50

Open TechMindsYT opened 7 years ago

TechMindsYT commented 7 years ago

RadioPlayerService adds android.permission.READ_PHONE_STATE to final manifest. This causes an issue with requiring a Privacy Policy on the app listing.

What is the reason for requesting android.permission.READ_PHONE_STATE in the final Manifest and can it be removed?

albedinsky commented 7 years ago

The reason why the RadioPlayerService adds the android.permission.READ_PHONE_STATE may be found here at line 218. If you look at the phoneStateListener implementation, you will see that it handles changes in a call state of an Android device where the player service is running, and it stops the radio playback whenever there is an incoming/outgoing call, remembers that the playback has been active, and when the call ends, that listener will again start the radio playback for the current radio Url.

I think this is an obvious expected behavior as we do not want to interrupt a user's incoming/outgoing call with the Radio playback.