iammike / simple-image-library

Someone on the internet requested a barebones Photo Library viewer for their special needs son. Sounded like an interesting and simple project, and my two toddlers would benefit from it as well.
0 stars 0 forks source link

Stop using GeometryReader for DetailView content #49

Closed iammike closed 7 months ago

iammike commented 7 months ago

It really shouldn't be necessary and causes issues if we want to use one elsewhere. They stack or something? Anyway, there is interference.

.aspectRatio(contentMode: .fit) is a solid option, but doesn't display landscape videos in landscape very well.

Perhaps move the view sizing into the actual views? Video player could continue using GeometryReader, while image viewer could use aspectRatio since it would get most benefit from the GeomteryReader - pinch/zoom/pan functionality.