iamolegga / nestjs-pino

Platform agnostic logger for NestJS based on Pino with REQUEST CONTEXT IN EVERY LOG
MIT License
1.26k stars 98 forks source link

Default asynchronous logging configuration #1031

Closed jhonatasobrinho closed 2 years ago

jhonatasobrinho commented 2 years ago

Question I looked into the nestjs-pino docs and the pinojs docs and both differ from what is correct about the defaut configuration over sync/async logging.

Based on pinojs it should be sync: false by default, but based on nestjs-pino documentation, it is sync: true the default. I made a research on the code and nestjs-pino doesn't modify the defaults on pinoHttp object.

Can someone confirm the default configuration for this property, please?

The documentation was modified last time on the merge of the #907.

iamolegga commented 2 years ago

Not sure if this is related to this lib. nestjs-pino just pass pino-http config to pino-http library. That's it. All the settings are up to you.

based on nestjs-pino documentation, it is sync: true the default

default is pino instance without config.