search

iampueroo / rComments

Chrome and Firefox extension for quickly exploring Reddit comments and replies without having to click through to the post!
http://iampueroo.github.io/rComments/
38 stars 3 forks source link

Make it work on Firefox. #5

Closed efskap closed 4 years ago

efskap commented 5 years ago

There seems to be a difference in how Chrome and FF handle xmlhttprequests to relative urls. i.e. /r/foo/comments/bar won't work without https://www.reddit.com prepended to it.

This small change makes it work in Firefox too (about:debugging -> load temporary extension -> manifest.json to try it)

I also signed an xpi for my own use

Resolves: #2

azizLIGHT commented 5 years ago

Wow. Thank you so much for doing this. Your XPI works perfect

iampueroo commented 4 years ago

More than a year later I'm seeing this.... 🤦

Thank you @efskap for this pull request! I've merged it in. I'll be publishing a new version very soon, I want to relaunch the extension (in both chrome and firefox). I definitely have let it die recently.....

iampueroo commented 4 years ago

@efskap @azizLIGHT published! Unfortunately I had to remove the voting feature - it seems to have broken with the new reddit redesign and I couldn't find a simple way to bring it back.

azizLIGHT commented 4 years ago

@efskap @azizLIGHT published! Unfortunately I had to remove the voting feature - it seems to have broken with the new reddit redesign and I couldn't find a simple way to bring it back.

FWIW, voting worked fine on old.reddit.com on both Firefox and Chrome! Hopefully we can get it back soon

iampueroo commented 4 years ago

@azizLIGHT thanks for letting me know, I thought it wasn't working but it may have been after making some changes to the request functions. I've created an issue for bringing back the old.reddit.com voting functionality