search

iamriajul / adhan-dart

Adhan for Dart / Muslim Prayer Times Library. Now retrieving Prayer time in Dart easier than ever.
https://pub.dev/packages/adhan
MIT License
87 stars 41 forks source link

Dart null safety support #14

Closed iamriajul closed 3 years ago

iamriajul commented 3 years ago

Dart null safety: https://dart.dev/null-safety

Anas35 commented 3 years ago

If there is no WIP for migrating this package to null-safety, I would happy to make a PR.

iamriajul commented 3 years ago

If there is no WIP for migrating this package to null-safety, I would happy to make a PR.

You're welcome, you can make a PR. Jazhaka Allahu Khairan.

Anas35 commented 3 years ago

Look like three package doesn't support Null-Safety

migrating a package without the null safety packages that depend on this package is discouraged.

Should we wait for these three projects to migrate?

iamriajul commented 3 years ago

I think we should wait.

iamriajul commented 3 years ago

although they are only dev dependencies, this package has no dependencies other than dev dependencies.

iamriajul commented 3 years ago

I think we can migrate only the lib folder (not test folder).

Anas35 commented 3 years ago

I think we can remove Strings package and we can find a workaround. It hasn't been used much in this project. As for dart_numeric, the last update was in 2018.

Anas35 commented 3 years ago

I think we can migrate only the lib folder (not test folder).

I don't think we can do that. If the lib folder changed, test might have some error.

iamriajul commented 3 years ago

As said Dart 2 is sound null safety, which means nullsafety code can be used from non-nullsafe code, they can co-exist. I think we shouldn't worry about the test, the test should run fine.

Anas35 commented 3 years ago

Ah! I get it. Will send a PR by tomorrow.

iamriajul commented 3 years ago

Published as prerelease: https://pub.dev/packages/adhan/versions/2.0.0-nullsafety.0 Try it out in your projects. and give feedback.