iamsankar / seaglass

Automatically exported from code.google.com/p/seaglass
0 stars 0 forks source link

JProgressBars with larger than 'default' heights are drawn too short #64

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
As you can see in the attachments, the 'Metal' L&F correctly aligns the bottom 
edge of the (disabled) JProgressBar with that of the adjacent JButton.  I need 
your very attractive 'SeaGlass' L&F to be doing the same.

Original issue reported on code.google.com by Xavio...@gmail.com on 31 Jan 2011 at 6:08

Attachments:

GoogleCodeExporter commented 9 years ago
We made a decision that we would support this in one size and not resize it. 
Would it be sufficient to properly center it?

Original comment by kahuxtable on 31 Jan 2011 at 3:28

GoogleCodeExporter commented 9 years ago
Without meaning to offend, I think that's a really bad design decision.  
Third-party L&Fs must possess the ability to resize any widgets that the 
default 'Metal' L&F can.

This is especially the case for a JProgressBar, which looks plain ugly in its 
default (skinny) dimensions.  I probably won't use 'SeaGlass' if this issue 
isn't fully fixed.

Original comment by Xavio...@gmail.com on 1 Feb 2011 at 12:40

GoogleCodeExporter commented 9 years ago
We discussed this and agree that we don't think this is a problem. We'll make 
sure it's centered and we'll add a client property to choose between a default, 
a small, and a large size.

Original comment by kahuxtable on 2 Feb 2011 at 4:41

GoogleCodeExporter commented 9 years ago
When you say that 'this' isn't a problem, does 'this' refer to "the current 
behaviour" or to "my request"?

Centring the JProgressBar is a good idea, but I dunno that including it in 
'small' and 'large' sizes will be useful.

Widgets need to be gradually resizable by the user at runtime, instead of 
coming in pre-determined (absolute) sizes.

As mentioned earlier, third-party L&Fs should consistently imitate the resizing 
capabilities of the default 'Metal' L&F.

Original comment by Xavio...@gmail.com on 3 Feb 2011 at 1:38

GoogleCodeExporter commented 9 years ago
We're not going to resize it. We think it would look awful. There are look and 
feel implementations that do not resize all widgets the way metal does. We are 
one of them. If you disagree you are free not to use it.

Original comment by kahuxtable on 3 Feb 2011 at 1:51

GoogleCodeExporter commented 9 years ago
It couldn't possibly look any worse than it currently does :-D.  It's not so 
much that I won't be using it, but rather that I might not recommend it to my 
users.

I won't make this decision until after you've centred it and added a 'large' 
size.  For this reason, please let me know once you've implemented these 
improvements.

Original comment by Xavio...@gmail.com on 3 Feb 2011 at 4:32