search

iamscottxu / obs-rtspserver

RTSP server plugin for obs-studio
https://obsproject.com/forum/resources/obs-rtspserver.1037/
GNU General Public License v2.0
441 stars 55 forks source link

No format parameters sent for video at DESCRIBE #24

Closed Fruchtzwerg94 closed 3 years ago

Fruchtzwerg94 commented 3 years ago

Publishing an RTSP stream includes the following DESCRIBE response for my video channel:

m=video 0 RTP/AVP 96
a=rtpmap:96 H264/90000
a=control:track0

The SDP: Session Description Protocol --> Section 6 also describes format parameters like

a=fmtp:<format> <format specific parameters>

This attribute allows parameters that are specific to a particular format to be conveyed in a way that SDP does not have to understand them. The format must be one of the formats specified for the media. Format-specific parameters may be any set of parameters required to be conveyed by SDP and given unchanged to the media tool that will use this format. At most one instance of this attribute is allowed for each format.

which may are required for some players to identify parameters like SPS and PPS to play the stream correctly. See: sprop-parameter-sets

Is it possible to add the format parameters to the DESCRIBE response?

For AAC audio this is already implemented: https://github.com/iamscottxu/obs-rtspserver/blob/5e27f335a9462adc446de2d240477e1d2c890cb0/rtsp-server/xop/AACSource.cpp#L77

but its basically missing at H264: https://github.com/iamscottxu/obs-rtspserver/blob/5e27f335a9462adc446de2d240477e1d2c890cb0/rtsp-server/xop/H264Source.cpp#L50

iamscottxu commented 3 years ago

https://github.com/iamscottxu/obs-rtspserver/releases/tag/v1.4.1-rc1

Fruchtzwerg94 commented 3 years ago

Wow, that was fast. I've tested it, works for me! Keep on doing like this, thanks!