search

iamscottxu / obs-rtspserver

RTSP server plugin for obs-studio
https://obsproject.com/forum/resources/obs-rtspserver.1037/
GNU General Public License v2.0
441 stars 55 forks source link

Optimization #25

Closed iamscottxu closed 3 years ago

iamscottxu commented 3 years ago

Add hotkey support. (#11) Support to start obs-rtspserver programmatically. (#23)

AWilco commented 3 years ago

Hi @iamscottxu

Thanks for looking into my issue so quickly. I hadn't even got around to looking into it myself!

I've compiled and tested your changes in this PR. The programmatic starting works in my use case, with OBS-Websocket.

I was thrown by the change of name used in obs_ouput_create. The string used here is what I use to reference this particular output (as I think you have to get outputs using get_output_by_name()). If it changes in a new version, or with the locale as it seems here, then other plugins etc will not be able to find this output. Appreciate this is presumably the text that appears in the settings menu, so you can't avoid it? If so, I'll make sure I keep mine compatible. I can also do a workaround looking for any output with RTSP in the name if I have to.

I also tested your HotKeys for starting and stopping. Appeared in the settings page fine and worked for me.