search

iamsergio / flow-pomodoro

A pomodoro app that blocks distractions while you work
https://github.com/iamsergio/flow-pomodoro
GNU General Public License v2.0
72 stars 11 forks source link

Hardcoded libdir #4

Closed mrueg closed 9 years ago

mrueg commented 9 years ago

In https://github.com/iamsergio/flow-pomodoro/blob/master/plugins/distractions/CMakeLists.txt#L14

On 64-bit systems you want to install it to lib64 instead.

iamsergio commented 9 years ago

I checked the Filesystem Hierarchy Standard and doesn't enforce that, in fact I checked archlinux and ubuntu and both have 64bit binaries in lib/

Maybe the best way is to have an optional argument passed to cmake so it's configurable

mrueg commented 9 years ago

I guess something like ${LIB_INSTALL_DIR} will work, too? See http://librelist.com/browser//yajl/2010/3/25/patch-install-into-usr-lib64-on-x86-64-arch-where-needed/

iamsergio commented 9 years ago

fixed with c1062dcdb03a9c3f9