search

iamshadmirza / react-native-design-system

A tiny design system
https://www.npmjs.com/package/react-native-design-system
MIT License
237 stars 31 forks source link

Typing is wrong for Input's onChangeText. #15

Closed gablabelle closed 4 years ago

gablabelle commented 4 years ago

Hello,

FYI, value is optional (it works without it being set), typing should be value?: string

https://github.com/iamshadmirza/react-native-design-system/blob/8f8a8ae603b1967d6f4e10d8302265bae4fa7fe2/src/types/Input.d.ts#L13

and onChangeText is missing the text it's returning, typing should be onChangeText: (text: string) => void,

https://github.com/iamshadmirza/react-native-design-system/blob/8f8a8ae603b1967d6f4e10d8302265bae4fa7fe2/src/types/Input.d.ts#L14

iamshadmirza commented 4 years ago

Fixed