iamshadmirza / react-native-design-system

A tiny design system
https://www.npmjs.com/package/react-native-design-system
MIT License
237 stars 31 forks source link

Example of textStyle for MenuAddButton #18

Closed in2progress closed 4 years ago

in2progress commented 4 years ago

Hi,

I am trialling out your framework and have tried to set the inner style of the the MenuAddButton Component.

Example as per below: <MenuAddButton style={{backgroundColor:'green', borderRadius:20}} textStyle={{backgroundColor:'white'}} onIncrement={handleIncrement} onDecrement={handleDecrement} count={count} />

The background colour remains grey after incrementing.

Please assist.

iamshadmirza commented 4 years ago

Will create a demo and add it. Give me a day.

iamshadmirza commented 4 years ago

Hey @in2progress This is fixed. Please install the latest version 1.2.1 Thanks for reporting.

in2progress commented 4 years ago

Hi,

Unfortunately failing with different error now.

Before clicking.

image

After clicking

image

Same code: <MenuAddButton style={{backgroundColor:'green', borderRadius:20}} textStyle={{backgroundColor:'white'}} onIncrement={handleIncrement} onDecrement={handleDecrement} count={count} />

Fails with same error without textStyle attribute.

RN: 0.63 iOS: Simulator 13.6

iamshadmirza commented 4 years ago

Damn Reopening this issue Sent a fix. Can you please confirm and close this issue if it works?

in2progress commented 4 years ago

That worked. Thank you!