search

iamshadmirza / react-native-design-system

A tiny design system
https://www.npmjs.com/package/react-native-design-system
MIT License
237 stars 31 forks source link

Add ToolTip #2

Open iamshadmirza opened 4 years ago

iamshadmirza commented 4 years ago

A ToolTip would be a good addition to the library. Let me know if you wanna take this issue. To setup development environment see contribution page here. You can see other components and try to follow the same structure.
ToolTip (/src/folder)

You can check out these two links for reference

A basic tooltip component has to be created at first. Then we will customize API according to the design rules of the system by adding some props like color, size, etc. This will be fun.

I am not sure if StoryBook will be appropriate for such a type of component so you can simply create a CRNA project also.

react-native init ToolTipDev

Go inside the project and then initialize as git

git init

add the repo as GitHub submodule

git submodule add https://github.com/iamshadmirza/react-native-design-system

Now you will have the project setup and your IDE will detect two separate Git Projects. React-Native-Design-System (bottom one) will commit to this project.

  1. Create a branch 
    cd react-native-design-system

    then

    git checkout -b <branch name>
  2. Make changes
  3. Create Pull Request
dhwanilvyas commented 4 years ago

Would like to take this up.

jasongaare commented 3 years ago

You have a nice design system! I particularly like the CircularProgress - much needed! (A lightweight CSS solution without bringing in other ART or SVG libs).

I'll drop another inspiration for your tooltips :) https://github.com/jasongaare/react-native-walkthrough-tooltip

iamshadmirza commented 3 years ago

Thank you @jasongaare , I'll add the tooltip soon.