search

iamshadmirza / react-native-design-system

A tiny design system
https://www.npmjs.com/package/react-native-design-system
MIT License
238 stars 31 forks source link

Overlay issue #22

Open in2progress opened 4 years ago

in2progress commented 4 years ago

RN: 0.63 Simulator: iOS 16.3

Three things:

  1. Overlay completely blanks out background screen.
  2. Clicking outside of Modal does not dismiss (if not a feature, should be :) )
  3. When setting visible back to false, onRequestClose is not firing.

`<Overlay visible={visible} onRequestClose={() => {console.log('modal closed')} }>

Hey there!

`

image image
iamshadmirza commented 4 years ago

I'm aware of this one, long overdue. Will fix over the weekend.