search

iamshreeram / hacktoberfest-2023

Hacktoberfest 2021 - Problems to solve in society based on location 😞
Apache License 2.0
1 stars 1 forks source link

added the location and updated the table #4

Closed prahasR closed 3 years ago

iamshreeram commented 3 years ago

@prahasR , Thanks for raising PR.

Few of the changes that I made are missing. Could you please do git pull before making changes to the code.

( OR ) You could,

  1. clone the repo (git clone https://github.com/iamshreeram/hacktoberfest-2021.git) again and
  2. cut a branch ( git checkout -b prahas-changes)
  3. make the changes that you did
  4. Add it all git add *,
  5. commit it - git commit -m "Adding location", and
  6. push your branch git push origin prahas-changes

Method 2 is right way of pushing the changes.

iamshreeram commented 3 years ago

I have updated How to contribute. See If this helps.

prahasR commented 3 years ago

@iamshreeram Thanks for the help, I just tried method 2 but it is saying "Permission to iamshreeram/hacktoberfest-2021.git denied to prahasR." . Can you help me with this. I think I can make changes to the forked repo only . And as I have already forked your repository so now I have to pull the changes you made after my forking...right? Can you please help me with doing this

iamshreeram commented 3 years ago

@prahasR , Thats right. You should be a collaborator or you will have to fork (this will in-turn create a new branch) and push it to master.

I made you as a collaborator to manage this repository. You should be able to push your changes to the repository directly now and also, you can manage the changes that others push.

Please try it now and let me know.

PS: Always please pull the latest changes git pull from the repository before pushing your changes.

prahasR commented 3 years ago

@iamshreeram Can you check now ...I resolved the conflict ....please let me know if you are able to merge my changes now?

iamshreeram commented 3 years ago

@prahasR , Merged your changes!

prahasR commented 3 years ago

Hey @iamshreeram I am glad that you merged it. Just wanted to ask whether it will be counted for hacktoberfest or not. I checked my profile and it is saying that "Matures in 14 days" . Can you help me by clarify this a little. What does it mean. Again happy to conribute

iamshreeram commented 3 years ago

@prahasR , Yes, this will be counted.