search

iamtalhaasghar / yewtube

Terminal based YouTube player and downloader. No Youtube API key required. Moved to https://github.com/mps-youtube/yewtube
GNU General Public License v3.0
245 stars 20 forks source link

Disable `selected_pafy_pls_id` (soft revert: d69a959) #89

Closed gdbiles closed 2 years ago

gdbiles commented 2 years ago

Fixes: https://github.com/iamtalhaasghar/yewtube/issues/75

Reverted commit intends to enable full playlist download (non-paginated). The change introduces bug when view does not set g.selected_pafy_pls_id prior to save.

This functionality was already available via dump command:

dump - to show entire contents of an opened YouTube playlist.
             (useful for playing or saving entire playlists, use undump to     undo)

Testing:

$ tail -n 5 ~/.config/mps-youtube/input_history
pl UUOkFff6Mg5YEyeZ8XONGc9A
save test_pl_nodump
dump
save test_pl_withdump
ls
      19  test_pl_nodump      36      38:30:36
      20  test_pl_withdump    177     130:33:26
iamtalhaasghar commented 2 years ago

did brought changes through 2552eff602683fbd28bc6841768bf6cf585fc960