Update application.yml - Githubissues

iamthechad / grails3-recaptcha

ReCaptcha plugin for Grails 3

Other

3 stars 10 forks source link

Update application.yml #11

Closed jameskleeh closed 9 years ago

jameskleeh commented 9 years ago

Remove production datasource to prevent adding config to a users production datasource

iamthechad commented 9 years ago

Two notes:

I don't see that application.yml is published with the plugin. I just checked the 3.0.0 binaries and this file is only packed with the sources jar.
If this truly is a problem, please submit a PR against the current target branch per https://github.com/iamthechad/grails3-recaptcha#contributing

jameskleeh commented 9 years ago

Per that link: "Be sure to submit pull requests against the current "target branch". This will ensure that changes are applied to the correct version."

What is the "target branch"? It is possible it's not included in the jar. I searched for the dbCreate text throughout all sources and it showed the setting in this plugin. Even so, why not remove it? Is there a compelling reason to leave it?

iamthechad commented 9 years ago

The target branch is called out just below the Table of Contents and again in the Contributing section:

jameskleeh commented 9 years ago

Created a new PR to the target branch