search

iamthechad / grails3-recaptcha

ReCaptcha plugin for Grails 3
Other
3 stars 10 forks source link

Add null safe check for getting response param #14

Closed jameskleeh closed 9 years ago

jameskleeh commented 9 years ago

If you would like to update it, go ahead, otherwise just close the PR as these minute details on a 1 character change PR are not worth the effort

iamthechad commented 9 years ago

These minute details are how I maintain the quality of the software. It's not just a one-character change because the unit test is just as important, and it's just as essential that it be correct.

If you're not comfortable with this, I'm sorry. Open an issue next time if you'd rather not have to deal with the details of changing code.

jameskleeh commented 9 years ago

I realize you are being difficult because you get some satisfaction from it. Given that you changed it in your 2.x codebase a half hour ago and could have simply changed the test to your liking here.

iamthechad commented 9 years ago

You can believe whatever you want. I have an expectation that submissions are complete and correct before I merge them. If that makes me difficult, then so be it.

What I'm asking is no different than what I've been asked to do as a contributor to other OSS projects. (It's actually easier. I could have asked you to squash your commits, use a very specific comment format, etc.)