iamtheyammer / fetch-ford-service-manuals

Downloads HTML and PDF versions of Ford Service Manuals from PTS
GNU General Public License v3.0
32 stars 12 forks source link

errno: -36, code: 'ENAMETOOLONG' #11

Closed kkkumar-1 closed 8 months ago

kkkumar-1 commented 8 months ago

Dear all,

Am trying to pull Ford Fiesta workshop manuals and am seeing error related to 'file name too long'

Can someone please help me with the issue? Please see the error screenshot.

![Uploading Screenshot 2024-02-09 160050.png…]()

Thanks in advance

iamtheyammer commented 8 months ago

@kkkumar-1 sent me a working screenshot via email:

image

On Ubuntu, the maximum path length is 256 characters, and, here, the attempted path is:

/2015-fiesta-test/2: Chassis/04: Suspension/204-02 Rear Suspension/Removal and Installation/Wheel Hub - 1.0L Duratec (48kW-65PS)-1.0L Duratec (59kW-80PS)-1.0L EcoBoost (74kW-100PS)-1.0L EcoBoost (90kW-120PS)-1.25L Duratec-16V (44kW-60PS) - Sigma-1.25L Duratec-16V (60kW-82PS) - Sigma-1.3L Z6 (83PS) - BZ-1.4L Duratec-16V (70kW-95PS) - Sigma-1.4L Duratec-16V (71kW-96PS) - Sigma-1.4L Duratec-16V Flex Fuel (71kW-96PS) - Sigma-1.4L Duratorq-TDCi (51kW-68PS)-1.5L Duratec-16V Flex Fuel (77kW-105PS)-1.5L Duratec-16V Ti-VCT (81kW-110PS) - Sigma-1.5L Duratorq-TDCi (55kW-75PS)-1.5L Duratorq-TDCi (67kW-91PS)-1.5L Z6 (101PS) - BZ-1.6L Duratec-16V Ti-VCT (77kW-105PS) - Sigma-1.6L Duratec-16V Ti-VCT (88kW-120PS) - Sigma-1.6L Duratec-16V Ti-VCT (99kW-134PS) - Sigma-1.6L Duratec-16V Ti-VCT Flex Fuel (92kW-125PS) - Sigma-1.6L Duratorq-TDCi (55kW-75PS)-1.6L Duratorq-TDCi (66kW-90PS)-1.6L Duratorq-TDCi (70kW-95PS) (T3)-1.6L Duratorq-TDCi (70kW-95PS) (TZ).html

Where the final file path is a whopping 850 characters (wow!). I'll have to add a check to truncate these insane filenames.

iamtheyammer commented 8 months ago

Should be fixed, so I'm closing this issue. Comment here to re-open it if it doesn't work.

kkkumar-1 commented 8 months ago

Hey Sam,

I checked the code on a completely new VM setup and unfortunately, the error remains the same. Kindly check the attached error screenshot

image

iamtheyammer commented 8 months ago

Shoot. Can you copy paste the error here?

On Mon, Feb 26 2024 at 07:23, kkkumar-1 < @.*** > wrote:

Hey Sam,

I checked the code on a completely new VM setup and unfortunately, the error remains the same. Kindly check the attached error screenshot

image.png (view on web) ( https://github.com/iamtheyammer/fetch-ford-service-manuals/assets/143082770/c5b71adc-0e0a-42db-a511-6abf444f9eee )

— Reply to this email directly, view it on GitHub ( https://github.com/iamtheyammer/fetch-ford-service-manuals/issues/11#issuecomment-1963400745 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AHUZB3SMTW3OY2KO64NKDATYVQS5XAVCNFSM6AAAAABDBHN5M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRTGQYDANZUGU ). You are receiving this because you modified the open/close state. Message ID: <iamtheyammer/fetch-ford-service-manuals/issues/11/1963400745 @ github . com>

kkkumar-1 commented 8 months ago

Downloading manual page Rear Suspension - Overview.html (docID: G1526781) Downloading manual page Rear Suspension.html (docID: G1604445) Downloading manual page Wheel Hub - 1.0L Duratec (48kW/65PS)/1.0L Duratec (59kW/80PS)/1.0L EcoBoost (74kW/100PS)/1.0L EcoBoost (90kW/120PS)/1.25L Duratec-16V (44kW/60PS) – Sigma/1.25L Duratec-16V (60kW/82PS) – Sigma/1.3L Z6 (83PS) – BZ/1.4L Duratec-16V (70kW/95PS) – Sigma/1.4L Duratec-16V (71kW/96PS) – Sigma/1.4L Duratec-16V Flex Fuel (71kW/96PS) – Sigma/1.4L Duratorq-TDCi (51kW/68PS)/1.5L Duratec-16V Flex Fuel (77kW/105PS)/1.5L Duratec-16V Ti-VCT (81kW/110PS) – Sigma/1.5L Duratorq-TDCi (55kW/75PS)/1.5L Duratorq-TDCi (67kW/91PS)/1.5L Z6 (101PS) – BZ/1.6L Duratec-16V Ti-VCT (77kW/105PS) – Sigma/1.6L Duratec-16V Ti-VCT (88kW/120PS) – Sigma/1.6L Duratec-16V Ti-VCT (99kW/134PS) – Sigma/1.6L Duratec-16V Ti-VCT Flex Fuel (92kW/125PS) – Sigma/1.6L Duratorq-TDCi (55kW/75PS)/1.6L Duratorq-TDCi (66kW/90PS)/1.6L Duratorq-TDCi (70kW/95PS) (T3)/1.6L Duratorq-TDCi (70kW/95PS) (TZ).html (docID: G1526788) -> Truncating filename, learn more in the README [Error: ENAMETOOLONG: name too long, open '/home/2015-Fiesta-attemp-1/2: Chassis/04: Suspension/204-02 Rear Suspension/Removal and Installation/Wheel Hub - 1.0L Duratec (48kW-65PS)-1.0L Duratec (59kW-80PS)-1.0L EcoBoost (74kW-100PS)-1.0L EcoBoost (90kW-120PS)-1.25L Duratec-16V (44kW-60PS) – Sigma-1.25L Duratec-16V (60kW-82PS) – Sigma-1.3L Z6 (83PS) – BZ-1.4L Duratec-16V (70kW (G1526788 truncated).html'] { errno: -36, code: 'ENAMETOOLONG', syscall: 'open', path: '/home/2015-Fiesta-attemp-1/2: Chassis/04: Suspension/204-02 Rear Suspension/Removal and Installation/Wheel Hub - 1.0L Duratec (48kW-65PS)-1.0L Duratec (59kW-80PS)-1.0L EcoBoost (74kW-100PS)-1.0L EcoBoost (90kW-120PS)-1.25L Duratec-16V (44kW-60PS) – Sigma-1.25L Duratec-16V (60kW-82PS) – Sigma-1.3L Z6 (83PS) – BZ-1.4L Duratec-16V (70kW (G1526788 truncated).html' }

iamtheyammer commented 8 months ago

Looks like the path is 260 once you add the file extension:

Wheel Hub - 1.0L Duratec (48kW-65PS)-1.0L Duratec (59kW-80PS)-1.0L EcoBoost (74kW-100PS)-1.0L EcoBoost (90kW-120PS)-1.25L Duratec-16V (44kW-60PS) – Sigma-1.25L Duratec-16V (60kW-82PS) – Sigma-1.3L Z6 (83PS) – BZ-1.4L Duratec-16V (70kW (G1526788 truncated).html

Just need to adjust the offsets.

iamtheyammer commented 8 months ago

File names are limited to 255 bytes, not 255 characters. Ford cleverly uses an emdash (–), a three-byte Unicode character, instead of the normal one-byte -. Added this to the illegal characters regex.

iamtheyammer commented 8 months ago

Should have been fixed in the most recent commit.

kkkumar-1 commented 8 months ago

Sam, you are a genius :-)

You have fixed it.

I really thank you once again for your time & efforts. Appreciate it.

On Mon, Feb 26, 2024 at 8:39 PM Sam @.***> wrote:

Should have been fixed in the most recent commit.

— Reply to this email directly, view it on GitHub https://github.com/iamtheyammer/fetch-ford-service-manuals/issues/11#issuecomment-1964371188, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCDUKERHLVHUBLUCNGLSFT3YVSQSZAVCNFSM6AAAAABDBHN5M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRUGM3TCMJYHA . You are receiving this because you were mentioned.Message ID: @.***>

iamtheyammer commented 8 months ago

Glad to hear it :)

Enjoy the manual!

On Mon, Feb 26 2024 at 17:51, kkkumar-1 < @.*** > wrote:

Sam, you are a genius :-)

You have fixed it.

I really thank you once again for your time & efforts. Appreciate it.

On Mon, Feb 26, 2024 at 8:39 PM Sam @.***> wrote:

Should have been fixed in the most recent commit.

— Reply to this email directly, view it on GitHub

https://github.com/iamtheyammer/fetch-ford-service-manuals/issues/11#issuecomment-1964371188,

or unsubscribe

https://github.com/notifications/unsubscribe-auth/BCDUKERHLVHUBLUCNGLSFT3YVSQSZAVCNFSM6AAAAABDBHN5M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRUGM3TCMJYHA

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub ( https://github.com/iamtheyammer/fetch-ford-service-manuals/issues/11#issuecomment-1964633769 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AHUZB3UCX5ORAQ44IYKKYC3YVS4Q3AVCNFSM6AAAAABDBHN5M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRUGYZTGNZWHE ). You are receiving this because you modified the open/close state. Message ID: <iamtheyammer/fetch-ford-service-manuals/issues/11/1964633769 @ github . com>