search

iamtheyammer / fetch-ford-service-manuals

Downloads HTML and PDF versions of Ford Service Manuals from PTS
GNU General Public License v3.0
32 stars 12 forks source link

Improved wiring support and updated cookie instructions #17

Closed KeltenP closed 4 months ago

KeltenP commented 5 months ago

I found this repo last week, and upon trying it out I found the manual was working fine but the wiring was not working at all. After reading some of the issues, looking at the open (but stale) pull request, and taking a look at some of the forks, I took a stab at getting this into decent working condition again.

These changes improves wiring downloads, including:

I was also having issues with cookies and seemingly not having the right ones. I've updated the instructions in the README file for retrieving additional cookies and this seems to be working well.

Using these updates I was able to download the full manual, all wiring (including every page for every wiring section) and all connector views for the following vehicles:

Unfortunately I ran out of time to test any older vehicles (e.g. pre-2003). I did add some TODOs into the code for some obvious changes that need to be made to get those working.

This is my first time working in TypeScript/nodejs. So hopefully this code is mostly up to snuff :)

buckchoklit commented 5 months ago

@KeltenP Amazing work! I grabbed the code from this PR and was able to get most of the wiring diagrams loaded. However, it seems to be having issues with the connectors on a 2017 F150.

iamtheyammer commented 5 months ago

Hey, thanks so much for this awesome PR. Will check it out and get it merged this weekend. Really appreciate your hard work!

KeltenP commented 5 months ago

@buckchoklit do you happen to have the terminal output of the failure?

Could you open the toc.json file in your Wiring folder, find the entry for the connectors (likely number 150) and post it here?

buckchoklit commented 5 months ago

I don't have terminal output any longer, as I was running this on an Ubuntu VM that's already shut down. My subscription also ran out.

However, the error was net::ERR_HTTP2_PROTOCOL_ERROR. I believe this is a server side issue caused by IIS based on this stack overflow article.

https://stackoverflow.com/questions/58215104/whats-the-neterr-http2-protocol-error-about

Basically IIS on the server side has a setting called "minBytesPerSecond" that cuts the connection because it thinks its a "slow drip" DDOS.

I was able to pull down the connectors for a 2003 F150 with no issue. However, the vehicles I looked at 2014+ all had issues.

Yes, it was always #150 where th issue started. I don't know any TypeScript but I know enough to read and navigate through the code, so I had chat GPT write a try/except block that'd skip the connectors if they three an error--this way I could grab all of the other diagrams after the connectors.

On Sat, Jun 1, 2024, 1:07 AM Kelten @.***> wrote:

@buckchoklit https://github.com/buckchoklit do you happen to have the terminal output of the failure?

Could you open the toc.json file in your Wiring folder, find the entry for the connectors (likely number 150) and post it here?

— Reply to this email directly, view it on GitHub https://github.com/iamtheyammer/fetch-ford-service-manuals/pull/17#issuecomment-2143297115, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWQ277TPZ4PJ6YJURPE74CTZFFJKXAVCNFSM6AAAAABIOIRXXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTGI4TOMJRGU . You are receiving this because you were mentioned.Message ID: @.***>

iamtheyammer commented 4 months ago

Got a PTS login from @strictlysimple, so I've modified your work and it's ready the lovely folks in #21 to test out.

Merging into experimental-wiring in case there are bugs as they run it, then I'll merge into main.

Thanks again to @KeltenP for this awesome PR!